Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_data.py to capture context key #98

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

aakankshaduggal
Copy link
Member

The key for context is seed_context but we were looking for context, that was just resulting in all grounded skills to take the freeform workflow instead. With this change, it is getting the seed_context and using the grounded workflow when generating data.

Addresses #97

The key for context is `seed_context` but we were looking for `context`, that was just resulting in all grounded skills to take the freeform workflow instead. With this change, it is getting the seed_context and using the grounded workflow when generating data.

Signed-off-by: Aakanksha Duggal <[email protected]>
@russellb
Copy link
Member

russellb commented Jul 8, 2024

I think we should make pipelines have to explicitly define their input expectations.

  1. It would be easier to integrate with. This has happened a few times.
  2. We can provide much better error handling to make this sort of thing super clear when it happens.

@russellb
Copy link
Member

russellb commented Jul 8, 2024

I think we should make pipelines have to explicitly define their input expectations.

  1. It would be easier to integrate with. This has happened a few times.
  2. We can provide much better error handling to make this sort of thing super clear when it happens.

to be clear, I wasn't suggesting that has to be done for this PR. It was more comments for the future (I actually thought I was looking at an issue instead of a PR at first!)

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! good catch

@russellb russellb merged commit 3327b55 into instructlab:main Jul 8, 2024
11 checks passed
jwm4 pushed a commit to jwm4/sdg that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants