Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: replace old small job with new medium job (backport #277) #283

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2024

this commit adds a new E2E job meant to test integration of training library changes with the CLI's "full" train pipeline to prevent any regressions

it also updates the relevant mergify configuration


This is an automatic backport of pull request #277 done by Mergify.

Copy link
Contributor Author

mergify bot commented Oct 19, 2024

Cherry-pick of c8439e0 has failed:

On branch mergify/bp/release-v0.5/pr-277
Your branch is up to date with 'origin/release-v0.5'.

You are currently cherry-picking commit c8439e0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/mergify.yml
	deleted:    .github/workflows/e2e-nvidia-t4-x1.yml
	modified:   README.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/e2e-nvidia-a10g-x1.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Oct 19, 2024
@mergify mergify bot added CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation release-branch ci-failure labels Oct 19, 2024
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we may need to merge manually

@mergify mergify bot added one-approval and removed ci-failure labels Oct 19, 2024
this commit adds a new E2E job meant to test integration
of training library changes with the CLI's "full" train
pipeline to prevent any regressions

it also updates the relevant mergify configuration

Signed-off-by: Nathan Weinberg <[email protected]>
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti Maxusmusti force-pushed the mergify/bp/release-v0.5/pr-277 branch from a90fcd2 to b731902 Compare October 21, 2024 11:57
@mergify mergify bot added the ci-failure label Oct 21, 2024
@mergify mergify bot removed the one-approval label Oct 21, 2024
@Maxusmusti Maxusmusti merged commit 150feb8 into release-v0.5 Oct 21, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration ci-failure conflicts documentation Improvements or additions to documentation release-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants