Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Added CHANGELOG.md #315

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Lo-Mein
Copy link
Contributor

@Lo-Mein Lo-Mein commented Oct 31, 2024

This PR introduces a CHANGELOG.md file to maintain a clear history of all changes, organized by version and type of change.

Resolves issue #209

Signed-off-by: Lo-Mein [email protected]

@mergify mergify bot added documentation Improvements or additions to documentation ci-failure labels Oct 31, 2024
@Lo-Mein Lo-Mein force-pushed the documentation/changelog branch from d0d7a41 to 72b9fa7 Compare October 31, 2024 17:18
@mergify mergify bot removed the ci-failure label Oct 31, 2024
@danmcp
Copy link
Member

danmcp commented Nov 5, 2024

@Lo-Mein You'll need to address the linting errors for this PR to be able to merge: https://github.com/instructlab/training/actions/runs/11616705508/job/32390208095?pr=315

Signed-off-by: Lo-Mein <[email protected]>
Signed-off-by: Lo-Mein <[email protected]>
@Lo-Mein Lo-Mein force-pushed the documentation/changelog branch from 8c3dffb to d18e572 Compare November 5, 2024 17:20
@mergify mergify bot removed the ci-failure label Nov 5, 2024
@nathan-weinberg
Copy link
Member

Can you squash commits please @Lo-Mein?

@RobotSail
Copy link
Member

@JamesKunstle @Maxusmusti Could you two please review this as well to ensure this isn't missing anything?

@JamesKunstle
Copy link
Contributor

@RobotSail since this is a commit heading dump I don't think this misses anything. Going forward I'd like to switch from doing commit header changelogs and use hand-written changelogs when necessary, but this is an appreciated contribution!

@mergify mergify bot merged commit 87dc3cc into instructlab:main Nov 8, 2024
6 checks passed
@mergify mergify bot removed the one-approval label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants