-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh/actions unit test workflows #384
Conversation
37621af
to
c18287f
Compare
c18287f
to
da92dd4
Compare
@courtneypacheco @bjhargrave could y'all PTAL at this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a few questions besides Nathan's, but looks good otherwise!
da92dd4
to
7d0d695
Compare
48dd6eb
to
343b70f
Compare
343b70f
to
823eca5
Compare
c9ebf6e
to
b72ac75
Compare
@danmcp @nathan-weinberg @bjhargrave Could you please look at the failure that the job is getting and help figure out why the workflow can't access |
b72ac75
to
f97b7de
Compare
It's not going to be able to access the variable from a fork PR with a new workflow. |
@danmcp Oh, duh. Of course it can't. |
f97b7de
to
11f7dac
Compare
11f7dac
to
28fa9f1
Compare
Signed-off-by: James Kunstle <[email protected]>
28fa9f1
to
d30978b
Compare
Adds a workflow to run our unit tests via tox on an EC2 runner. Runs: