Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using AutoConfig to load model config file. #416

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Using AutoConfig to load model config file. #416

merged 3 commits into from
Feb 4, 2025

Conversation

abhi1092
Copy link
Member

  • Right now loading from local file causes the code to fail on HF checkpoints.
  • This should fix that issue

@mergify mergify bot added the ci-failure label Jan 27, 2025
@abhi1092
cleaning linting issues
d7b8edb 
Signed-off-by: Abhishek Bhandwaldar <[email protected]>
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 27, 2025
@mergify mergify bot added ci-failure and removed ci-failure labels Jan 28, 2025
Maxusmusti
Maxusmusti approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the one-approval label Jan 29, 2025
@abhi1092 abhi1092 requested a review from RobotSail January 30, 2025 21:08
@mergify mergify bot removed the one-approval label Jan 30, 2025
@JamesKunstle JamesKunstle merged commit 89c5bd5 into instructlab:main Feb 4, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxusmusti Maxusmusti Maxusmusti approved these changes

@RobotSail RobotSail RobotSail approved these changes

@aldopareja aldopareja Awaiting requested review from aldopareja

Assignees
No one assigned
Labels
ci-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhi1092 @Maxusmusti @RobotSail @JamesKunstle