Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding custom chat template / special token support #54

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Adding custom chat template / special token support #54

merged 9 commits into from
Jun 21, 2024

Conversation

Maxusmusti
Copy link
Contributor

To support more than just the currently hard-coded IBM generic special tokens / chat template.

@Maxusmusti Maxusmusti force-pushed the chat-templates branch 2 times, most recently from e044fd8 to b6f023e Compare June 21, 2024 15:12
@Maxusmusti
First pass chat template (backend only)
a64ffa5 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Module path importing
fa973a0 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Fix missing sys handling
0a69954 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Connecting chat templates to the interface
b1b11eb 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Fix file-paths
fbb6af6 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Typo fixes
07b6662 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Fixed template imports
0db67f6 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@aldopareja aldopareja marked this pull request as ready for review June 21, 2024 15:59
RobotSail
RobotSail approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things but otherwise LGTM

JamesKunstle
JamesKunstle approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@JamesKunstle JamesKunstle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Oleg's recommendations have been resolved.

@Maxusmusti
Review feedback applied
16b9e88 
Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti
Remove extraneous slash
d0dcef0 
Signed-off-by: Mustafa Eyceoz <[email protected]>
RobotSail
RobotSail approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maxusmusti Maxusmusti merged commit 08647d7 into main Jun 21, 2024
5 of 6 checks passed
This was referenced Jun 27, 2024
Closed
Closed
@Maxusmusti Maxusmusti deleted the chat-templates branch July 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobotSail RobotSail RobotSail approved these changes

@JamesKunstle JamesKunstle JamesKunstle approved these changes

@aldopareja aldopareja aldopareja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Maxusmusti @aldopareja @JamesKunstle @RobotSail