Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes: Small batch barrier and Broken model loading #72

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Maxusmusti
Copy link
Contributor

Fixes model loading on multi-gpu setups and also raises an error when batch sizes are too small for multipack sampling

@Maxusmusti Maxusmusti merged commit 60dc322 into main Jun 25, 2024
7 checks passed
nathan-weinberg pushed a commit to nathan-weinberg/training that referenced this pull request Jun 27, 2024
Fixes model loading on multi-gpu setups and also raises an error when batch sizes are too small for multipack sampling

---------

Signed-off-by: Mustafa Eyceoz <[email protected]>
nathan-weinberg pushed a commit to nathan-weinberg/training that referenced this pull request Jun 27, 2024
Fixes model loading on multi-gpu setups and also raises an error when batch sizes are too small for multipack sampling

---------

Signed-off-by: Mustafa Eyceoz <[email protected]>
nathan-weinberg pushed a commit to nathan-weinberg/training that referenced this pull request Jun 27, 2024
Fixes model loading on multi-gpu setups and also raises an error when batch sizes are too small for multipack sampling

---------

Signed-off-by: Mustafa Eyceoz <[email protected]>
@Maxusmusti Maxusmusti deleted the small-batch-barrier branch July 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants