Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Horizon] Update CourseDetails screen #3044

Merged
merged 4 commits into from
Jan 9, 2025
Merged

[Horizon] Update CourseDetails screen #3044

merged 4 commits into from
Jan 9, 2025

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93 Ahmed-Naguib93 commented Dec 28, 2024 •
edited
Loading

@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Dec 28, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Dec 28, 2024 •
edited
Loading

Horizon Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 28, 2024 •
edited
Loading

Fails
🚫 Build failed, skipping coverage check
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor 
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testAutomaticRead 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113010600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x600000721080>>".
XCTAssertNotNil failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113010600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x600000721080>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x113010600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x600000721080>>".
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testLayout 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10882d000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000072e040>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10882d000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000072e040>>".
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10882d000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000072e040>>".
XCTAssertTrue failed
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x10882d000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000072e040>>".
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowEntry 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x106081a00; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x6000007341a0>>".
XCTAssertEqual failed: ("nil") is not equal to ("Optional("4")")
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testShowReplies 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x112816000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x600000729460>>".
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopic 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x1090a1000; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000071d6a0>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testStudentGroupTopicWhenUserNotInAGroup 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x108848600; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x60000072f100>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed
❌ XCTest failed: CoreTests/DiscussionDetailsViewControllerTests/testTeacherGroupTopic 
Asynchronous wait failed: Exceeded timeout of 9 seconds, with unfulfilled expectations: "Expect predicate `runningCount == 0` for object <_TtCC9CoreTests36DiscussionDetailsViewControllerTests11MockWebView: 0x11281d800; frame = (0 0; 375 100); opaque = NO; backgroundColor = <UIDynamicCatalogColor: 0x600002380f00; name = backgroundLightest>; layer = <CALayer: 0x600000729ce0>>".
XCTAssertTrue failed
XCTAssertTrue failed
XCTAssertTrue failed

Generated by 🚫 dangerJS against 51e17fe

szabinst
szabinst requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole screen looks much better!

Left some comments below.

Horizon/Horizon/Sources/Common/Data/HModuleItem.swift Outdated Show resolved Hide resolved
...s/HorizonUI/Sources/Components/Cards/ModuleItemCard/HorizonUI.ModuleItemCard.Storybook.swift Outdated Show resolved Hide resolved
...ources/HorizonUI/Sources/Components/Cards/ModuleItemCard/HorizonUI.ModuleItemCard.Type.swift Outdated Show resolved Hide resolved
...nUI/Sources/HorizonUI/Sources/Components/Cards/ModuleItemCard/HorizonUI.ModuleItemCard.swift Outdated Show resolved Hide resolved
packages/HorizonUI/Sources/HorizonUI/Sources/Components/Tabs/HorizonUI.Tabs.Storybook.swift Outdated Show resolved Hide resolved
...s/HorizonUI/Sources/Components/Cards/ModuleItemCard/HorizonUI.ModuleItemCard.Storybook.swift Outdated Show resolved Hide resolved
@szabinst szabinst merged commit 3d51a15 into feature/horizon Jan 9, 2025
2 of 4 checks passed
@szabinst szabinst deleted the feature/horizon-CLX-150-Update-CourseDetails-screen branch January 9, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabinst szabinst szabinst approved these changes

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

@reabbotted reabbotted Awaiting requested review from reabbotted reabbotted is a code owner

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst is a code owner

Assignees

@Ahmed-Naguib93 Ahmed-Naguib93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ahmed-Naguib93 @inst-danger @szabinst