Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging Dart exceptions in Rust #138

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Logging Dart exceptions in Rust #138

merged 15 commits into from
Dec 11, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Nov 2, 2023 •
edited by tyranron
Loading

Synopsis

Exceptions in the Dart function called from Rust are not printed.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::logging Related to application logs labels Nov 2, 2023
@rogurotus rogurotus self-assigned this Nov 2, 2023
@rogurotus
Copy link
Contributor Author

rogurotus commented Nov 3, 2023 •
edited by tyranron
Loading

FCM:

Log exceptions thrown from Dart callbacks called by Rust (#138)

Additionally:
- upgrade `medea_flutter_webrtc` to 0.9 version

@alexlapa
Merge branch 'master' into log-dart-exception
ab96634 
# Conflicts:
#	flutter/lib/src/native/connection_handle.dart
#	flutter/lib/src/native/media_manager.dart
#	flutter/lib/src/native/room_handle.dart
#	flutter/test/e2e/steps/given.dart
#	flutter/test/e2e/world/member.dart
#	src/api/dart/api_bridge_generated.io.rs
@alexlapa
corrections
95269d0
@alexlapa
changelog
5e4227f
@alexlapa alexlapa self-requested a review December 8, 2023 15:12
@alexlapa alexlapa marked this pull request as ready for review December 8, 2023 15:14
@alexlapa alexlapa requested a review from tyranron December 8, 2023 17:32
@tyranron tyranron enabled auto-merge (squash) December 11, 2023 15:50
@tyranron tyranron merged commit ff31e43 into master Dec 11, 2023
47 of 48 checks passed
@tyranron tyranron deleted the log-dart-exception branch December 11, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::logging Related to application logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogurotus @tyranron @alexlapa