Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add reactive collections to the medea-reactive crate (#27) #103

Merged
merged 5 commits into from
May 21, 2020
Merged

Add reactive collections to the medea-reactive crate (#27) #103

merged 5 commits into from
May 21, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented May 20, 2020 •
edited
Loading

Part of #27

Required for #100

Related to #47

Synopsis

State snapshots (used for states synchronization) from the #100 uses collections and this collections
should be reactive on a client side.

Solution

Implement observable analogs for the standard collections.

Std collection Reactive analog
HashMap ObservableHashMap
HashSet ObservableHashSet
Vec ObservableVec

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels May 20, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone May 20, 2020
@evdokimovs evdokimovs self-assigned this May 20, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented May 20, 2020 •
edited by tyranron
Loading

FCM

Add ObseravbleHashMap, ObservableHashSet and ObservableVec reactive collections to 'medea-reactive' crate (#103, #27)

@evdokimovs evdokimovs marked this pull request as ready for review May 20, 2020 16:24
@evdokimovs evdokimovs requested a review from alexlapa May 20, 2020 16:25
@alexlapa alexlapa requested a review from tyranron May 20, 2020 23:21
@tyranron tyranron changed the title WIP: Add reactive collections to the medea-reactive crate (#27) Add reactive collections to the medea-reactive crate (#27) May 21, 2020
tyranron
tyranron reviewed May 21, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@tyranron tyranron self-requested a review May 21, 2020 13:07
tyranron
tyranron approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😵

@evdokimovs evdokimovs merged commit e61d4ad into master May 21, 2020
@evdokimovs evdokimovs deleted the reactive-collections branch May 21, 2020 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

@alexlapa alexlapa alexlapa approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa