Implements member and members repository #13

Kirguir · 2019-01-17T10:39:53Z

Add struct for member and members repository implemented on actix actor.
Repository handle GetMember and GetMemberByCredentials messages for retrieve member by its id or credentials.

tyranron

@Kirguir merge with master after !12 and resend for a review.

Kirguir

@tyranron merged with !12

tyranron

Consider feedback below.

src/api/control/member.rs

Kirguir · 2019-01-25T08:10:34Z

@tyranron изменения запушил, как повторно отправить на ревью?

Kirguir

@tyranron cc

tyranron

@Kirguir please, more attention to code style. All missed docs should be filled up.

@alexlapa there is something strange with the idea of baking MemberRepository into Actor. You should carefully reconsider it.

src/main.rs

src/errors/mod.rs

src/api/control/member.rs

Kirguir

@tyranron removed implementation of actor for member repository. Implemented simple functions for gets member from repo.

Kirguir

@tyranron cc

tyranron

Still, there were a lot of missing docs. I've fixed this up.

However, implemented API requires to be refactored and simplified.

src/api/control/member.rs

src/main.rs

Kirguir

@tyranron cc

tyranron

With changes now it's OK.

However, I don't see any FCM.

src/api/control/member.rs

Kirguir · 2019-01-31T09:54:17Z

@tyranron FCM

Implement member entity and member repository (#13, #10)

- add default caller and responder into repository

- add default caller and responder into repository

tyranron · 2019-01-31T12:21:25Z

@Kirguir do not use force-push on GitHub. It erases the whole PR history. GitHub has "squash merge" button. Use it directly. This has been mentioned in workflow, please re-read.

Kirguir self-assigned this Jan 17, 2019

Kirguir added feature New feature or request k::design Related to overall design and/or architecture labels Jan 17, 2019

Kirguir added this to the 0.1.0 milestone Jan 17, 2019

Kirguir requested a review from alexlapa January 17, 2019 12:07

alexlapa requested a review from tyranron January 18, 2019 05:43

alexlapa approved these changes Jan 18, 2019

View reviewed changes

tyranron suggested changes Jan 18, 2019

View reviewed changes

Kirguir commented Jan 18, 2019

View reviewed changes

alexlapa mentioned this pull request Jan 18, 2019

Medea server 1 <=> 1 WebRTC P2P #10

Closed

16 tasks

tyranron suggested changes Jan 21, 2019

View reviewed changes

Kirguir commented Jan 25, 2019

View reviewed changes

alexlapa requested a review from tyranron January 25, 2019 15:08

tyranron suggested changes Jan 28, 2019

View reviewed changes

src/main.rs Show resolved Hide resolved

src/errors/mod.rs Outdated Show resolved Hide resolved

src/errors/mod.rs Outdated Show resolved Hide resolved

src/api/control/member.rs Outdated Show resolved Hide resolved

Kirguir commented Jan 28, 2019

View reviewed changes

Kirguir commented Jan 29, 2019

View reviewed changes

tyranron suggested changes Jan 29, 2019

View reviewed changes

src/api/control/member.rs Outdated Show resolved Hide resolved

src/api/control/member.rs Outdated Show resolved Hide resolved

src/api/control/member.rs Outdated Show resolved Hide resolved

Kirguir commented Jan 30, 2019

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

Kirguir commented Jan 31, 2019

View reviewed changes

tyranron suggested changes Jan 31, 2019

View reviewed changes

src/api/control/member.rs Outdated Show resolved Hide resolved

tyranron approved these changes Jan 31, 2019

View reviewed changes

Implement member and member repository (!13, #10)

d435099

- add default caller and responder into repository

Kirguir force-pushed the add_member branch from c23fb2d to d435099 Compare January 31, 2019 10:23

Kirguir changed the title ~~WIP: Implements member and members repository~~ Implements member and members repository Jan 31, 2019

Kirguir merged commit faca6d3 into master Jan 31, 2019

Kirguir deleted the add_member branch January 31, 2019 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements member and members repository #13

Implements member and members repository #13

Kirguir commented Jan 17, 2019

tyranron left a comment

Kirguir left a comment

tyranron left a comment

Kirguir commented Jan 25, 2019

Kirguir left a comment

tyranron left a comment

Kirguir left a comment

Kirguir left a comment

tyranron left a comment

Kirguir left a comment

tyranron left a comment

Kirguir commented Jan 31, 2019 •

edited by tyranron

Loading

tyranron commented Jan 31, 2019

Implements member and members repository #13

Implements member and members repository #13

Conversation

Kirguir commented Jan 17, 2019

tyranron left a comment

Choose a reason for hiding this comment

Kirguir left a comment

Choose a reason for hiding this comment

tyranron left a comment

Choose a reason for hiding this comment

Kirguir commented Jan 25, 2019

Kirguir left a comment

Choose a reason for hiding this comment

tyranron left a comment

Choose a reason for hiding this comment

Kirguir left a comment

Choose a reason for hiding this comment

Kirguir left a comment

Choose a reason for hiding this comment

tyranron left a comment

Choose a reason for hiding this comment

Kirguir left a comment

Choose a reason for hiding this comment

tyranron left a comment

Choose a reason for hiding this comment

Kirguir commented Jan 31, 2019 • edited by tyranron Loading

tyranron commented Jan 31, 2019

Kirguir commented Jan 31, 2019 •

edited by tyranron

Loading