This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Implement multiple Rooms support (#27) #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # jason/e2e-demo/js/index.js # jason/src/api/room.rs
evdokimovs
added
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
labels
Oct 8, 2020
This was referenced Oct 8, 2020
alexlapa
approved these changes
Nov 2, 2020
tyranron
reviewed
Nov 4, 2020
tyranron
suggested changes
Nov 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to redesign that protocol thing.
tyranron
changed the title
Draft: Implement multiple Rooms support (#27)
Implement multiple Rooms support (#27)
Nov 6, 2020
tyranron
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27
Synopsis
Jason should be able to serve multiple
Room
s with oneJason
object. If Jason client joins to the manyRoom
s from the one Media Server, then only one WebSocket connection should serve all thisRoom
s.Solution
Add authorization messages to the
medea-client-api-proto
. AuthorizeMember
s with this messages instead of doing it by URL with whichMember
connects to the Media Server.Create wrapper around Jason's
WebSocketRpcClient
which will be responsible for routing and sessions management.Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removede2e-demo
changes are rollbacked