Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Disable PeerTrafficWatcher and CoturnMetricsService #166

Merged
merged 5 commits into from
Dec 23, 2020
Merged

Disable PeerTrafficWatcher and CoturnMetricsService #166

merged 5 commits into from
Dec 23, 2020

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Dec 22, 2020 •
edited by tyranron
Loading

Synopsis

Эти компоненты необходимы для реализации on_start / on_stop коллбеков (#91). Так как та задача переносится на следующий milestone, а эти компоненты в данный момент доставляют определенный дискомфорт и в любом случае будут дорабатываться, было решено их временно выключить.

Solution

Disable PeerTrafficWatcher and CoturnMetricsService.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::design Related to overall design and/or architecture k::monitoring Related to monitoring capabilities labels Dec 22, 2020
@alexlapa alexlapa self-assigned this Dec 22, 2020
@alexlapa
Copy link
Collaborator Author

alexlapa commented Dec 22, 2020 •
edited by tyranron
Loading

FCM:

Disable PeerTrafficWatcher and CoturnMetricsService (#166)

Additionally:
- upgrade Firefox to 84.0 version for E2E tests
- upgrade 'rand' crate to 0.8 version

@alexlapa alexlapa added this to the 0.2.0 milestone Dec 22, 2020
@alexlapa alexlapa requested a review from tyranron December 22, 2020 14:32
@tyranron tyranron added the rollback Rollback of some changes label Dec 22, 2020
@tyranron tyranron changed the title Draft: Disable PeerTrafficWatcher and CoturnMetricsService Disable PeerTrafficWatcher and CoturnMetricsService Dec 22, 2020
@alexlapa alexlapa marked this pull request as ready for review December 23, 2020 09:15
@alexlapa alexlapa merged commit 4b56c63 into master Dec 23, 2020
@alexlapa alexlapa deleted the disable-coturn-metrics-and-traffic-watcher branch December 23, 2020 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::design Related to overall design and/or architecture k::monitoring Related to monitoring capabilities rollback Rollback of some changes
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlapa @tyranron