This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Fully migrate MediaStates management to reactivity (#27, #47) #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # jason/tests/peer/mod.rs
…a into reactive-media-state
This reverts commit 640d1c9.
…a into reactive-media-state
…a into reactive-media-state
alexlapa
approved these changes
Jan 26, 2021
tyranron
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvement of existing features or bugfix
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27
Required for #167
Synopsis
Currently intentions of the
Sender
s/Receiver
s will be sent byRoom
object, but it will be more correct ifCommand::UpdateTracks
will be sent onState
updates.Also in this PR, disable/mute before call will be more correctly implemented. Now
Command::UpdateTrack
will be sent afterEvent::PeerCreated
, but before negotiation start.Solution
Migrate
MediaState
management ofSender
/Receiver
to the reactivity.Send
Command::UpdateTrack
s based on constraints before negotiation start.Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed