Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Fully migrate MediaStates management to reactivity (#27, #47) #174

Merged
merged 151 commits into from
Jan 27, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jan 15, 2021

Part of #27

Required for #167

Synopsis

Currently intentions of the Senders/Receivers will be sent by Room object, but it will be more correct if Command::UpdateTracks will be sent on State updates.

Also in this PR, disable/mute before call will be more correctly implemented. Now Command::UpdateTrack will be sent after Event::PeerCreated, but before negotiation start.

Solution

Migrate MediaState management of Sender/Receiver to the reactivity.

Send Command::UpdateTracks based on constraints before negotiation start.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa requested a review from tyranron January 26, 2021 15:18
@tyranron tyranron changed the title Draft: Fully migrate MediaStates management to the reactivity (#27, #47) Fully migrate MediaStates management to reactivity (#27, #47) Jan 27, 2021
@evdokimovs evdokimovs merged commit df0ba1d into master Jan 27, 2021
@evdokimovs evdokimovs deleted the reactive-media-state branch January 27, 2021 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants