Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement Control API basic Apply method (#27) #187

Merged
merged 29 commits into from
Apr 8, 2021
Merged

Implement Control API basic Apply method (#27) #187

merged 29 commits into from
Apr 8, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 15, 2021 •
edited by tyranron
Loading

Part of #27

Synopsis

This PR implements Room, Member and Endpoints creation/deletion with Apply method. Patching of Member or Endpoint settings is not part of this PR.

Solution

  • 1. Add Apply method to the Control API proto
  • 2. Add Apply method to the Control API mock
  • 3. Implement elements creation with Apply:
    • 3.1 Room
    • 3.2 Member
    • 3.3 WebRtcPlayEndpoint/WebRtcPublishEndpoint
  • 4. Implement elements deletion with Apply:
    • 4.1 Room
    • 4.2 Member
    • 4.3 WebRtcPlayEndpoint/WebRtcPublishEndpoint
  • 5. Add E2E tests for Apply method

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) labels Mar 15, 2021
@evdokimovs evdokimovs self-assigned this Mar 15, 2021
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 15, 2021 •
edited by alexlapa
Loading

FCM

Implement Control API basic Apply method (#187, #27)

- add Apply method to 'medea-control-api-proto'
- add PUT HTTP endpoints to the 'medea-control-api-mock' crate
- implement elements creation/deletion with Apply Control API method

Additionally:
- fix token generation for existing Member in Medea demo

evdokimovs and others added 9 commits March 15, 2021 12:59
@evdokimovs
Upd CHANGELOGs
28f92d9
@evdokimovs
Fix doc
df05388
@alexlapa
Merge branch 'master' into control-api-apply
ca7ad18 
# Conflicts:
#	Cargo.toml
@alexlapa
cargo update
d86ce88
@alexlapa
Merge branch 'master' into control-api-apply
f5ee7cb 
# Conflicts:
#	Cargo.lock
#	src/signalling/elements/member.rs
#	src/signalling/room/dynamic_api.rs
#	tests/e2e/steps/control_api.rs
@alexlapa
review
2271317
@evdokimovs
Fix for WebRtcPlayEndpoint delete
174db85
@evdokimovs
Add E2E tests, fix bug
eb42dd0
@alexlapa
review
5314bfe
@alexlapa alexlapa marked this pull request as ready for review April 5, 2021 07:13
@alexlapa alexlapa requested a review from tyranron April 5, 2021 07:15
@alexlapa alexlapa added this to the 0.2.0 milestone Apr 5, 2021
tyranron
tyranron suggested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More polishing is required

mock/control-api/CHANGELOG.md Outdated Show resolved Hide resolved
src/api/control/member.rs Show resolved Hide resolved
@alexlapa alexlapa requested a review from tyranron April 5, 2021 11:34
tyranron
tyranron suggested changes Apr 6, 2021
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh... please, consider the given feedback for all the sources not only for the mentioned ones.

Do a full diff comparison before requesting a review.

src/signalling/room_service.rs Show resolved Hide resolved
src/signalling/room_service.rs Show resolved Hide resolved
tests/e2e/world/mod.rs Show resolved Hide resolved
tests/e2e/world/mod.rs Show resolved Hide resolved
@evdokimovs evdokimovs requested a review from alexlapa April 7, 2021 03:43
@alexlapa alexlapa requested a review from tyranron April 8, 2021 06:09
@tyranron tyranron changed the title Draft: Implement Control API basic Apply method (#27) Implement Control API basic Apply method (#27) Apr 8, 2021
@tyranron tyranron merged commit 2f1b351 into master Apr 8, 2021
@tyranron tyranron deleted the control-api-apply branch April 8, 2021 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa