Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Mock Control Server #36

Merged
merged 917 commits into from
Oct 31, 2019
Merged

Mock Control Server #36

merged 917 commits into from
Oct 31, 2019

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jul 17, 2019

Part of #27

Synopsis

Need create REST API server which acts as user-friendly wrapper for gRPC Control API interface.
This is needed for simplification of E2E testing Control API.

Solution

  • Create
    • Room
      • Serialization from JSON to protobuf
      • Single
    • Member
      • Serialization from JSON to protobuf
      • Single
    • Endpoint
      • Serialization from JSON to protobuf
      • Single
  • Get
    • Room
      • Serialization from protobuf to JSON
      • Single
    • Member
      • Serialization from protobuf to JSON
      • Single
    • Endpoint
      • Serialization from protobuf to JSON
      • Single
  • Delete
    • Room single
    • Member single
    • Endpoint single
  • Don't use medea in control-api-mock

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::testing Related to testing and/or automated tests labels Jul 17, 2019
@evdokimovs evdokimovs added this to the 0.2.0 milestone Jul 17, 2019
@evdokimovs evdokimovs self-assigned this Jul 17, 2019
@tyranron tyranron force-pushed the master branch 3 times, most recently from 8f9956c to 7432f56 Compare August 21, 2019 14:55
@evdokimovs evdokimovs requested a review from tyranron October 28, 2019 10:48
@alexlapa alexlapa self-requested a review October 28, 2019 19:52
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed to bikeshed POST / endpoints for consitency with other HTTP endpoitns.

Also:

  • renamed crate to medea-control-api-mock;
  • moved it to live in mock/control-api/ directory.

Makefile Outdated Show resolved Hide resolved
crates/control-api-mock/README.md Outdated Show resolved Hide resolved
jason/demo/chart/medea-demo/values.yaml Outdated Show resolved Hide resolved
@evdokimovs evdokimovs requested a review from alexlapa October 30, 2019 09:28
@alexlapa alexlapa requested a review from tyranron October 31, 2019 12:34
@tyranron tyranron added the k::toolchain Related to project toolchain label Oct 31, 2019
@evdokimovs evdokimovs changed the title WIP: Mock Control Server Mock Control Server Oct 31, 2019
@evdokimovs evdokimovs merged commit f0a5f5f into master Oct 31, 2019
@evdokimovs evdokimovs deleted the control-api-mock-server branch October 31, 2019 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::testing Related to testing and/or automated tests k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants