Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Send reason of WebSocket close by server #58

Merged
merged 9 commits into from
Oct 10, 2019
Merged

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Oct 8, 2019

Part of #27

Required for #33 and #55

Synopsis

We need to send reason of WebSocket closing by server to client.

Solution

  • 1. Add reasons to medea-client-api-proto
  • 2. Send this reasons from Medea on WebSocket close

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Oct 8, 2019
@evdokimovs evdokimovs added this to the 0.2.0 milestone Oct 8, 2019
@evdokimovs evdokimovs self-assigned this Oct 8, 2019
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Oct 9, 2019

FCM

Send reason of WebSocket close by server (#58)

- add CloseDescription and CloseReason to 'medea-client-api-proto' crate
- send CloseDescription when closing WebSocket connection on Medea side

@evdokimovs evdokimovs marked this pull request as ready for review October 9, 2019 15:26
@evdokimovs evdokimovs requested a review from alexlapa October 9, 2019 15:26
@alexlapa alexlapa requested a review from tyranron October 9, 2019 15:55
@evdokimovs evdokimovs changed the title WIP: Send reason of WebSocket close by server Send reason of WebSocket close by server Oct 10, 2019
@evdokimovs evdokimovs merged commit 3d71e23 into master Oct 10, 2019
@evdokimovs evdokimovs deleted the client-api-close-reason branch October 10, 2019 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants