Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Drop Coturn sessions via Telnet #84

Merged
merged 23 commits into from
Feb 19, 2020
Merged

Drop Coturn sessions via Telnet #84

merged 23 commits into from
Feb 19, 2020

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Feb 12, 2020 •
edited by tyranron
Loading

Synopsis

We want to have guaranteed way to drop media transmission.

Solution

If peers are connected via turn server, we can cancel corresponding session on Coturn via admin telnet cli.

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@alexlapa alexlapa added feature New feature or request k::api Related to API (application interface) k::security Related to security labels Feb 12, 2020
@alexlapa alexlapa added this to the 0.2.0 milestone Feb 12, 2020
@alexlapa alexlapa self-assigned this Feb 12, 2020
@alexlapa
Copy link
Collaborator Author

FCM:

Drop Coturn sessions via telnet (#84)

- add 'medea-coturn-telnet' crate to access Coturn admin interface
- add '[turn.cli]' config section to configure access to Coturn admin interface
- add '[turn.cli.pool]' config section to configure connection pool to  Coturn admin interface
- drop user sessions on Coturn server when deleting credentials

@alexlapa alexlapa marked this pull request as ready for review February 12, 2020 11:02
@alexlapa alexlapa requested a review from tyranron February 12, 2020 11:02
@tyranron tyranron added k::design Related to overall design and/or architecture enhancement Improvement of existing features or bugfix and removed k::api Related to API (application interface) labels Feb 14, 2020
tyranron
tyranron suggested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires polishing.

crates/medea-coturn-telnet/Cargo.toml Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/Cargo.toml Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/Cargo.toml Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/Cargo.toml Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet/src/lib.rs Outdated Show resolved Hide resolved
jason/demo/chart/medea-demo/values.yaml Outdated Show resolved Hide resolved
config.toml Outdated Show resolved Hide resolved
@alexlapa alexlapa force-pushed the drop-coturn-sessions-via-telnet branch from 17eefe7 to 4d2e7dc Compare February 17, 2020 09:09
@alexlapa alexlapa requested a review from tyranron February 17, 2020 10:58
tyranron
tyranron approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM

Drop Coturn sessions via Telnet (#84)

- create 'medea-coturn-telnet-client' crate to access Coturn admin interface via Telnet
- add [turn.cli] and [turn.cli.pool] config sections
- drop Coturn user sessions on Coturn server while deleting its credentials

Additionally:
- upd 'medea-demo' Helm chart with new config options
- use original names of Coturn config options in 'medea-demo' Helm chart values
- fix [turn.db.redis] docs and types
- use --all-features flag when testing sub-crates
- update Dockerfiles to consider new sub-crate

crates/medea-coturn-telnet-client/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet-client/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet-client/src/lib.rs Show resolved Hide resolved
crates/medea-coturn-telnet-client/src/lib.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet-client/src/framed.rs Outdated Show resolved Hide resolved
crates/medea-coturn-telnet-client/src/framed.rs Outdated Show resolved Hide resolved
config.toml Outdated Show resolved Hide resolved
src/conf/turn.rs Outdated Show resolved Hide resolved
jason/demo/chart/medea-demo/values.yaml Outdated Show resolved Hide resolved
jason/demo/chart/medea-demo/templates/secret.server.yaml Outdated Show resolved Hide resolved
@tyranron tyranron changed the title WIP: Drop Coturn sessions via telnet Drop Coturn sessions via Telnet Feb 19, 2020
@alexlapa alexlapa merged commit f615f74 into master Feb 19, 2020
@alexlapa alexlapa deleted the drop-coturn-sessions-via-telnet branch February 19, 2020 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::design Related to overall design and/or architecture k::security Related to security
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlapa @tyranron