Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Configure Member's RPC connection settings via Control API (#27) #95

Merged
merged 22 commits into from
Apr 7, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 23, 2020

Part of #27

Synopsis

We need to add configuration of the idle_timeout, reconnect_timeout and ping_interval by Control API. This settings can be configured in Member element spec. If no settings provided into spec, default values from the config will be used.

Solution

  • 1. Add reconnect_timeout, idle_timeout and ping_interval fields into specs
  • 2. Use this fields in the WsSession
  • 3. Add unit and E2E tests for this functional
  • 4. Add this fields into e2e-demo's Control API UI

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::config Related to application configuration labels Mar 23, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Mar 23, 2020
@evdokimovs evdokimovs self-assigned this Mar 23, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Mar 24, 2020

FCM

Configure Member's RPC connection settings via Control API (#95, #27)

- add 'idle_timeout', 'reconnect_timeout' and 'ping_interval' to Member spec in Control API
- add RPC connection configuration fields to the 'e2e-demo' and 'medea-control-api-mock'

@evdokimovs evdokimovs changed the title WIP: Add RPC connection timeouts configuration by Control API WIP: Add RPC Member's RPC connection configuration by Control API Mar 24, 2020
@evdokimovs evdokimovs marked this pull request as ready for review March 24, 2020 16:33
@evdokimovs evdokimovs requested a review from alexlapa March 24, 2020 16:34
# Conflicts:
#	CHANGELOG.md
#	Cargo.lock
#	mock/control-api/Cargo.toml
#	src/signalling/participants.rs
#	tests/e2e/signalling/mod.rs
@alexlapa alexlapa changed the title WIP: Add RPC Member's RPC connection configuration by Control API WIP: Configure Member's RPC connection settings via Control API Mar 30, 2020
@alexlapa alexlapa requested a review from tyranron March 30, 2020 15:20
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs please, polish the docs accross the project a bit more better, without loosing current context.

proto/control-api/Cargo.toml Show resolved Hide resolved
proto/control-api/Cargo.toml Outdated Show resolved Hide resolved
proto/control-api/src/grpc/api.proto Outdated Show resolved Hide resolved
proto/control-api/src/grpc/api.proto Show resolved Hide resolved
@evdokimovs evdokimovs requested a review from alexlapa April 1, 2020 13:31
@alexlapa alexlapa requested a review from tyranron April 1, 2020 13:52
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evdokimovs hyperium/tonic#314 is resolved as .gitignore comment suggests, and tonic 0.2 is out.

I've checked using Config::compile_well_known_types, but, as reffered in docs, it requires now to specify .proto files for well-known types by ourselves and doesn't use prost-types anymore. This is absolutely not something intended for resolving this issue.

If so, I suggest just to delete this empty generated file manually in build.rs and that's it!

@evdokimovs evdokimovs requested a review from alexlapa April 2, 2020 14:52
@alexlapa alexlapa requested a review from tyranron April 2, 2020 17:58
@tyranron tyranron changed the title WIP: Configure Member's RPC connection settings via Control API Configure Member's RPC connection settings via Control API (#27) Apr 7, 2020
@evdokimovs evdokimovs merged commit 43b9242 into master Apr 7, 2020
@evdokimovs evdokimovs deleted the control-api-rpc-timeout branch April 7, 2020 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::api Related to API (application interface) k::config Related to application configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants