Skip to content

Commit

Permalink
Fix syslogd not running in Debian (instrumentisto/opendkim-docker-i…
Browse files Browse the repository at this point in the history
  • Loading branch information
tyranron committed Oct 4, 2022
1 parent 93ac5c9 commit e3673bd
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 4 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,20 @@ All user visible changes to this project will be documented in this file. This p



## [1.4.2-r14] · 2022-10-04
[1.4.2-r14]: /../../tree/1.4.2-r14

[Diff](/../../compare/1.4.2-r13...1.4.2-r14)

### Fixed

- `syslogd` not running in [Debian]. ([instrumentisto/opendkim-docker-image#6])

[instrumentisto/opendkim-docker-image#6]: https://github.com/instrumentisto/opendkim-docker-image/issues/6




## [1.4.2-r13] · 2022-08-30
[1.4.2-r13]: /../../tree/1.4.2-r13

Expand Down
5 changes: 5 additions & 0 deletions Dockerfile.tmpl.php
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@
https://github.com/just-containers/s6-overlay/releases/download/v${s6_overlay_ver}/s6-overlay-x86_64.tar.xz \
&& tar -xf /tmp/s6-overlay-noarch.tar.xz -C / \
&& tar -xf /tmp/s6-overlay-bin.tar.xz -C / \
<? if (!$isAlpineImage) { ?>
\
# Fix syslogd path
&& ln -s /usr/sbin/syslogd /sbin/syslogd \
<? } ?>
\
# Cleanup unnecessary stuff
<? if ($isAlpineImage) { ?>
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ REGISTRIES := $(strip $(subst $(comma), ,\
$(shell grep -m1 'registry: \["' .github/workflows/ci.yml \
| cut -d':' -f2 | tr -d '"][')))
ALL_IMAGES := \
debian:1.4.2-r13,1.4.2,1.4,1,latest \
alpine:1.4.2-r13-alpine,1.4.2-alpine,1.4-alpine,1-alpine,alpine
debian:1.4.2-r14,1.4.2,1.4,1,latest \
alpine:1.4.2-r14-alpine,1.4.2-alpine,1.4-alpine,1-alpine,alpine
# <Dockerfile>:<version>,<tag1>,<tag2>,...

# Default is first image from ALL_IMAGES list.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ OpenDMARC Docker image

## Supported tags and respective `Dockerfile` links

- [`1.4.2-r13`, `1.4.2`, `1.4`, `1`, `latest`][101]
- [`1.4.2-r13-alpine`, `1.4.2-alpine`, `1.4-alpine`, `1-alpine`, `alpine`][102]
- [`1.4.2-r14`, `1.4.2`, `1.4`, `1`, `latest`][101]
- [`1.4.2-r14-alpine`, `1.4.2-alpine`, `1.4-alpine`, `1-alpine`, `alpine`][102]



Expand Down
3 changes: 3 additions & 0 deletions debian/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ RUN apt-get update \
&& tar -xf /tmp/s6-overlay-noarch.tar.xz -C / \
&& tar -xf /tmp/s6-overlay-bin.tar.xz -C / \
\
# Fix syslogd path
&& ln -s /usr/sbin/syslogd /sbin/syslogd \
\
# Cleanup unnecessary stuff
&& apt-get purge -y --auto-remove \
-o APT::AutoRemove::RecommendsImportant=false \
Expand Down
7 changes: 7 additions & 0 deletions tests/main.bats
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,10 @@
'opendmarc && sleep 10 && ls /run/opendmarc/another-one.pid'
[ "$status" -eq 0 ]
}


@test "syslogd: runs ok" {
run docker run --rm --entrypoint sh $IMAGE -c \
'/sbin/syslogd --help'
[ "$status" -eq 0 ]
}

0 comments on commit e3673bd

Please sign in to comment.