Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migtd: record hash of event in event log #309

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/migtd/src/event_log.rs
Original file line number Diff line number Diff line change
@@ -94,9 +94,9 @@ pub fn write_tagged_event_log(
tagged_event_data: &[u8],
) -> Result<usize> {
let mut log_size = event_log_size(event_log).ok_or_else(|| anyhow!("Parsing event log"))?;
let event = TaggedEvent::new(tagged_event_id, tagged_event_data);

let digest = calculate_digest(tagged_event_data)?;
let event = TaggedEvent::new(tagged_event_id, &digest);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The digest is already recorded.

I think we only need to add descriptor.
Please refer to https://trustedcomputinggroup.org/resource/pc-client-specific-platform-firmware-profile-specification/


extend_rtmr(&digest, 3)?;

let event_header = CcEventHeader {
Loading