Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock/virtio-serial: pop all the received packets #310

Closed

Conversation

gaojiaqi7
Copy link
Contributor

@gaojiaqi7 gaojiaqi7 commented Oct 21, 2024

After receiving from vsock/virtio-serial transport layer, pop all the data packet from device and try to fill the caller's buffer as much as possible.

@jyao1
Copy link
Contributor

jyao1 commented Oct 22, 2024

please update serial as well.

@gaojiaqi7 gaojiaqi7 force-pushed the 1021/pop_all_vsock_packet_from_device branch from 87a8c93 to 7bf7394 Compare October 23, 2024 07:08
@gaojiaqi7 gaojiaqi7 changed the title vsock: pop all the received packets vsock/virtio-serial: pop all the received packets Oct 28, 2024
Copy link
Contributor

@liuw1 liuw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyao1 jyao1 linked an issue Nov 1, 2024 that may be closed by this pull request
@liuw1
Copy link
Contributor

liuw1 commented Nov 6, 2024

Cross platform pre-migration test pass.

@jyao1
Copy link
Contributor

jyao1 commented Nov 8, 2024

Would you please fix the conflict?

After receiving from vsock transport layer, pop all the vsock packet
from device and try to fill the caller's buffer as much as possible.

Signed-off-by: Jiaqi Gao <[email protected]>
Pop all the received data from port queue and virtio queue and try to
fill the caller's buffer as much as possible after receiving from virtio
serial device.

Signed-off-by: Jiaqi Gao <[email protected]>
@gaojiaqi7 gaojiaqi7 force-pushed the 1021/pop_all_vsock_packet_from_device branch from f568ea1 to f59f92d Compare November 12, 2024 01:36
@gaojiaqi7 gaojiaqi7 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the failure with latest rustls version 0.23.13
3 participants