Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdt: implement GetCPUs() and SetCPUs() #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

rdt: implement GetCPUs() and SetCPUs() #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions pkg/rdt/rdt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ type ResctrlGroup interface {
// AddPids assigns the given process ids to the group
AddPids(pids ...string) error

// GetCPUs returns the cpu ids associated with the group
GetCPUs() (string, error)

// SetCPUs associates the given cpu ids with the group
SetCPUs(cpus ...string) error

// GetMonData retrieves the monitoring data of the group
GetMonData() MonData
}
Expand Down Expand Up @@ -644,6 +650,27 @@ func (r *resctrlGroup) AddPids(pids ...string) error {
return nil
}

func (r *resctrlGroup) GetCPUs() (string, error) {
data, err := rdt.readRdtFile(r.relPath("cpus_list"))
if err != nil {
return "", err
}
return strings.TrimSpace(string(data)), nil
}

func (r *resctrlGroup) SetCPUs(cpus ...string) error {
f, err := os.OpenFile(r.path("cpus_list"), os.O_WRONLY, 0644)
if err != nil {
return err
}
defer f.Close()

if _, err := f.WriteString(strings.Join(cpus, ",")); err != nil {
return rdtError("failed to associate cpus %v to class %q: %v", cpus, r.name, rdt.cmdError(err))
}
return nil
}

func (r *resctrlGroup) GetMonData() MonData {
m := MonData{}

Expand Down
31 changes: 31 additions & 0 deletions pkg/rdt/rdt_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ partitions:
if err := cls.AddPids("99"); err != nil {
t.Fatalf("AddPids() failed: %v", err)
}
if err := cls.SetCPUs("1"); err != nil {
t.Fatalf("SetCPUs() failed: %v", err)
}

// Configuration should fail as "Stale" class has pids assigned to it
if err := SetConfig(conf, false); err == nil {
Expand Down Expand Up @@ -286,6 +289,23 @@ partitions:

mockFs.verifyTextFile(rdt.classes["Guaranteed"].relPath("tasks"), "10\n11\n12\n")

// Verify assigning CPUs to classes (ctrl groups)
if p, err := cls.GetCPUs(); err != nil {
t.Errorf("GetCPUs() failed: %v", err)
} else if !cmp.Equal(p, "") {
t.Errorf("GetCPUs() returned %s, expected an empty string", p)
}
cpus := []string{"4", "10-13"}
if err := cls.SetCPUs(cpus...); err != nil {
t.Errorf("SetCPUs() failed: %v", err)
}
if p, err := cls.GetCPUs(); err != nil {
t.Errorf("GetCPUs() failed: %v", err)
} else if !cmp.Equal(p, strings.Join(cpus, ",")) {
t.Errorf("GetCPUs() returned %s, expected %s", p, cpus)
}
mockFs.verifyTextFile(rdt.classes["Guaranteed"].relPath("cpus_list"), "4,10-13")

// Verify MonSupported and GetMonFeatures
if !MonSupported() {
t.Errorf("MonSupported() returned false, expected true")
Expand Down Expand Up @@ -376,6 +396,17 @@ partitions:
}
mockFs.verifyTextFile(rdt.classes["Guaranteed"].monGroups[mgName].relPath("tasks"), "10\n")

// Verify assigning cpus to monitor group
if err := mg.SetCPUs("0-7"); err != nil {
t.Errorf("SetCPUs() failed: %v", err)
}
if p, err := mg.GetCPUs(); err != nil {
t.Errorf("GetCPUs() failed: %v", err)
} else if !cmp.Equal(p, "0-7") {
t.Errorf("GetCPUs() returned %s, expected 0-7", p)
}
mockFs.verifyTextFile(rdt.classes["Guaranteed"].monGroups[mgName].relPath("cpus_list"), "0-7")

// Verify monitoring functionality
expected := MonData{
L3: MonL3Data{
Expand Down