Skip to content

Commit

Permalink
[SYCL][Graph] Remove calls to urCommandBufferReleaseCommandExp (#16670)
Browse files Browse the repository at this point in the history
Reflects UR change from
oneapi-src/unified-runtime#2578 where we no
longer need to manually manage the lifetimes of the individual commands
in a UR command-buffer.
  • Loading branch information
EwanC authored Jan 29, 2025
1 parent eaa9c63 commit bf2b21e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
14 changes: 8 additions & 6 deletions sycl/cmake/modules/UnifiedRuntimeTag.cmake
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# commit 3a1b4c7b9ba952fad6f6ad36c01101bbf368347b
# Merge: c270a6b8 264d0468
# commit 14f4a3ba70b91b3adc411ec6bfc8ae86e948a990
# Merge: 4643d1c0 3ed86fae
# Author: Kenneth Benzie (Benie) <[email protected]>
# Date: Tue Jan 28 15:16:58 2025 +0000
# Merge pull request #2594 from kbenzie/benie/cl-core-functions-no-dlopen
# Fix invalid use of dlopen()
set(UNIFIED_RUNTIME_TAG 3a1b4c7b9ba952fad6f6ad36c01101bbf368347b)
# Date: Wed Jan 29 13:55:27 2025 +0000
#
# Merge pull request #2578 from Bensuo/ewan/remove_command_ref_counting
#
# Remove command-buffer command handle ref counting
set(UNIFIED_RUNTIME_TAG 14f4a3ba70b91b3adc411ec6bfc8ae86e948a990)
9 changes: 0 additions & 9 deletions sycl/source/detail/graph_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -951,15 +951,6 @@ exec_graph_impl::~exec_graph_impl() {
}
}
}

for (auto &Iter : MCommandMap) {
if (auto Command = Iter.second; Command) {
ur_result_t Res = Adapter->call_nocheck<
sycl::detail::UrApiKind::urCommandBufferReleaseCommandExp>(Command);
(void)Res;
assert(Res == UR_RESULT_SUCCESS);
}
}
} catch (std::exception &e) {
__SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~exec_graph_impl", e);
}
Expand Down

0 comments on commit bf2b21e

Please sign in to comment.