Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NATIVECPU][libclc]Mark opencl_c_generic_address_space as unsupported on Native CPU #13109

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

PietroGhg
Copy link
Contributor

Similarly to what is done for nvptx in #13015, Native CPU maps private and generic to the same address spaces, so we need to avoid getting multiple definitions for the libclc builtins that use generic.

@PietroGhg PietroGhg requested a review from a team as a code owner March 22, 2024 14:19
@PietroGhg PietroGhg requested a review from frasercrmck March 22, 2024 14:19
Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one typo. Thanks!

@PietroGhg
Copy link
Contributor Author

@intel/llvm-gatekeepers this looks ready to be merged, thank you

@sommerlukas sommerlukas merged commit 8847c11 into intel:sycl Mar 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants