[UR] Enable hwloc in UMF linux build

[PatKamin]

Update UR to statically link UMF with hwloc on Linux.
This will enable hwloc support in UMF on Linux.

Also, always use the v2.9.3 hwloc version for hwloc builds.

[PatKamin]

Drafted until the UMF fix is pulled down to llvm via UMF update in UR.

[PatKamin]

Drafted until the UMF fix is pulled down to llvm via UMF update in UR.

Fix is now pulled down, ready for review.

[igchor]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

[PatKamin]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

Right, now it will automatically be downloaded - deleted user requirement.

[bader]

Update UR to statically link hwloc v2.9.3 both on linux and Windows.

If I get the change right, the dependency on hwloc still exists. The change removed the runtime dependency, but not the compile time dependency. Am I right?

This document describes the environment for DPC++ compiler developers, not DPC++ compiler users.

Your change seems to raise the version requirement. Please, update the hwloc version to 2.9.3.

[PatKamin]

The hwloc library will always be fetched from sources. Regardless of hwloc-dev packages user has installed, the fetched version will be linked with the UMF library. That's why I remove hwloc from this dependencies list, as the user-installed hwloc-dev package will not be used by UMF.

[bader]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

Right, now it will automatically be downloaded - deleted user requirement.

If hwloc dependencies will be automatically resolved by CMake, please, remove installation of these dependencies from CI scripts. Specifically, from

llvm/devops/scripts/install_build_tools.sh

Line 26 in 7cc9e80

libhwloc-dev \

and

llvm/.github/workflows/sycl-docs.yml

Line 36 in 7cc9e80

sudo apt-get install -y graphviz ssh ninja-build libhwloc-dev

.

[PatKamin]

You should probably also update https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md (remove hwloc as a dependency that needs to be installed by the user)

Right, now it will automatically be downloaded - deleted user requirement.

If hwloc dependencies will be automatically resolved by CMake, please, remove installation of these dependencies from CI scripts. Specifically, from

llvm/devops/scripts/install_build_tools.sh

Line 26 in 7cc9e80

libhwloc-dev \

and

llvm/.github/workflows/sycl-docs.yml

Line 36 in 7cc9e80

sudo apt-get install -y graphviz ssh ninja-build libhwloc-dev

.

Thanks, done

[uditagarwal97]

Do we still need brew install hwloc on MacOS build CI workflow: https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-macos-build-and-test.yml#L33 ?

Update UR to statically link hwloc v2.9.3 both on linux and Windows.

I recall installing hwloc on Windows CI runners. Now that we are fetching hwloc from sources and statically linking it, am I good to remove hwloc installations on Windows CI runners once this PR gets merged?

Also, can you please update the PR title? - at the first glace it looked like the change is for Linux only. But the description says that the change is for both Windows and Linux.

[PatKamin]

Do we still need brew install hwloc on MacOS build CI workflow: https://github.com/intel/llvm/blob/sycl/.github/workflows/sycl-macos-build-and-test.yml#L33 ?

I've removed it now, it shouldn't be required anymore.

I recall installing hwloc on Windows CI runners. Now that we are fetching hwloc from sources and statically linking it, am I good to remove hwloc installations on Windows CI runners once this PR gets merged?

openmp still needs hwloc, so this can be done with a caution on Windows CI runners that are not used for openmp tests, I think.

Also, can you please update the PR title? - at the first glace it looked like the change is for Linux only. But the description says that the change is for both Windows and Linux.

I've updated the misleading commit message. hwloc already is linked to UMF statically on Windows even without this change.

[aarongreig]

UR LGTM

[uditagarwal97]

CI changes LGTM.