[SYCLCompat][E2E] Add sycl::free for allocated memory #16584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiang, Zhiwei <[email protected]>
zhiweij1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhiweij1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failed test |
|
Hi @joeatodd , please help review this PR. |
ProGTX
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Note that there might be issues if any calls between the allocation and the free throw, then free wouldn't actually get called. I quick glance suggests that's unlikely to happen, but it might be worth reworking at a later point - this is definitely a step in the right direction.
Signed-off-by: Jiang, Zhiwei <[email protected]>
zhiweij1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @ProGTX , I have updated the PR according to your comment. |
zhiweij1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ProGTX
approved these changes
Jan 13, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiang, Zhiwei [email protected]