Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Align execution_capability info with spec #16673

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

KseniyaTikhomirova
Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova commented Jan 17, 2025

Aligns behavior with https://github.com/KhronosGroup/SYCL-Docs/pull/625/files
Test update to pair it with: KhronosGroup/SYCL-CTS#1020

Done in RT for simplicity.
Since execution_capability is marked as deprecated I would suggest to make update in UR & UR adapters after it is completely removed.

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review January 23, 2025 14:26
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner January 23, 2025 14:26
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny nitpick.

sycl/source/detail/device_info.hpp Outdated Show resolved Hide resolved
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
@KseniyaTikhomirova
Copy link
Contributor Author

@intel/llvm-gatekeepers hi, this PR is ready to be merged. thanks.

@sarnex sarnex merged commit 4e5a72e into intel:sycl Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants