Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Extend scope of scheduler bypass to safe to bypass events #16735

Open
wants to merge 7 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Extend scope of scheduler bypass to safe to bypass events #16735

wants to merge 7 commits into from
+29 −15

Conversation

Alexandr-Konovalov
Copy link
Contributor

  1. Aling scheduler bypass conditions for CG and for memory ops.
  2. Connect an event returned from scheduler bypass case with dependent events.

@sergey-semenov sergey-semenov self-requested a review January 22, 2025 16:50
sergey-semenov
sergey-semenov reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, just minor nitpicks

sycl/source/detail/queue_impl.cpp Outdated Show resolved Hide resolved
sycl/unittests/scheduler/EnqueueWithDependsOnDeps.cpp Outdated
@@ -332,6 +332,9 @@ TEST_F(DependsOnTests, ShortcutFunctionWithWaitList) {
ASSERT_NE(Cmd, nullptr);
Cmd->MIsBlockable = true;
Cmd->MEnqueueStatus = detail::EnqueueResultT::SyclEnqueueBlocked;
// for the test functionality, depenent task HostTaskEvent must be treated as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this comment with "Mock up an incomplete host task" on L326.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as ready for review January 29, 2025 14:37
@Alexandr-Konovalov Alexandr-Konovalov requested a review from a team as a code owner January 29, 2025 14:37
@Alexandr-Konovalov
Copy link
Contributor Author

@intel/llvm-reviewers-runtime Colleagues, could you please look at the PR?

steffenlarsen
steffenlarsen reviewed Feb 6, 2025
View reviewed changes
sycl/source/detail/queue_impl.cpp Outdated
}

if (isInOrder()) {
auto &EventToStoreIn = MGraph.expired() ? MDefaultGraphDeps.LastEventPtr
: MExtGraphDeps.LastEventPtr;
EventToStoreIn = EventImpl;
EventToStoreIn = std::move(EventImpl);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make EventImpl a const auto & instead? That way, there would be no point in moving it here and we would avoid conditionally invalid future attempts at accessing EventImpl after this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

sycl/source/handler.cpp Show resolved Hide resolved
Alexandr-Konovalov and others added 7 commits February 6, 2025 15:38
@Alexandr-Konovalov
[SYCL] Extend scope of scheduler bypass to safe to bypass events
200f498 
1) Aling scheduler bypass conditions for CG and for memory ops.
2) Connect an event returned from scheduler bypass case with dependent
   events.
@Alexandr-Konovalov
Fix code formatting.
7545445
@Alexandr-Konovalov @sergey-semenov
Update sycl/source/detail/queue_impl.cpp
f415de9 
Co-authored-by: Sergey Semenov <[email protected]>
@Alexandr-Konovalov
Fix test-e2e.
38fd1f3
@Alexandr-Konovalov
Fix code formatting.
cb643fa
@Alexandr-Konovalov
Small fixes.
368b5da
@Alexandr-Konovalov
Eliminate excessive copying.
a4fa35a
@Alexandr-Konovalov Alexandr-Konovalov force-pushed the Alexandr-Konovalov/simplify-scheduler-bypass branch from 03df21e to a4fa35a Compare February 6, 2025 16:28
steffenlarsen
steffenlarsen approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it looks good, but I also would like to give @sergey-semenov another day to look.

sergey-semenov
sergey-semenov approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexandr-Konovalov @sergey-semenov @steffenlarsen