Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Switch default merge_ref to empty #16772

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[CI] Switch default merge_ref to empty #16772

merged 1 commit into from
Jan 24, 2025

Conversation

aelovikov-intel
Copy link
Contributor

There were a few places that didn't pass explicit '' and all of them were actual bugs:

  • sycl-nightly.yml didn't pass it for windows build and run-tests
  • sycl-nightly.yml didn't pass it for ubuntu2404_oneapi_build job (passed for other linux build jobs)

There were a few places that didn't pass explicit `''` and all of them were
actual bugs:

* `sycl-nightly.yml` didn't pass it for windows build and run-tests
* `sycl-nightly.yml` didn't pass it for `ubuntu2404_oneapi_build` job (passed
  for other linux build jobs)
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Jan 24, 2025

Running nightly testing for this change in https://github.com/intel/llvm/actions/runs/12956440497.

Update: failures are unrelated, I'm already working on resolving them.

@@ -10,7 +10,7 @@ inputs:
description: |
Commit-ish to merge post-checkout if non-empty. Must be reachable from the
default_branch input paramter.
default: 'FETCH_HEAD'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only place where we merge_commit is directly used in all of CI is in cached checkout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@aelovikov-intel
Copy link
Contributor Author

SYCL :: InOrderEventsExt/get_last_event.cpp on Arc GPU is unrelated.

@aelovikov-intel aelovikov-intel merged commit 1dbe403 into sycl Jan 24, 2025
43 of 48 checks passed
@aelovikov-intel aelovikov-intel deleted the fix-merge_ref branch January 24, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants