-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Switch default merge_ref
to empty
#16772
Conversation
There were a few places that didn't pass explicit `''` and all of them were actual bugs: * `sycl-nightly.yml` didn't pass it for windows build and run-tests * `sycl-nightly.yml` didn't pass it for `ubuntu2404_oneapi_build` job (passed for other linux build jobs)
Running nightly testing for this change in https://github.com/intel/llvm/actions/runs/12956440497. Update: failures are unrelated, I'm already working on resolving them. |
@@ -10,7 +10,7 @@ inputs: | |||
description: | | |||
Commit-ish to merge post-checkout if non-empty. Must be reachable from the | |||
default_branch input paramter. | |||
default: 'FETCH_HEAD' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only place where we merge_commit
is directly used in all of CI is in cached checkout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
|
There were a few places that didn't pass explicit
''
and all of them were actual bugs:sycl-nightly.yml
didn't pass it for windows build and run-testssycl-nightly.yml
didn't pass it forubuntu2404_oneapi_build
job (passed for other linux build jobs)