[SYCL][Graph] Add common reference semantics #16788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
d1ac215 to
8a2571d
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
8a2571d to
e786630
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
e786630 to
c547e3f
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Bensuo
reviewed
Jan 27, 2025
sycl/source/detail/graph_impl.cpp
Outdated
|
|
||
| size_t | ||
| std::hash<sycl::ext::oneapi::experimental::dynamic_command_group>::operator()( | ||
| const sycl::ext::oneapi::experimental::dynamic_command_group &DynamicCGH) |
There was a problem hiding this comment.
Suggested change
| const sycl::ext::oneapi::experimental::dynamic_command_group &DynamicCGH) | |
| const sycl::ext::oneapi::experimental::dynamic_command_group &DynamicCG) |
sycl/source/detail/graph_impl.hpp
Outdated
Comment on lines
1123
to
1124
| unsigned long long getID() { return MID; } | ||
|
|
There was a problem hiding this comment.
Think this function can be const, also applies to same function in other classes.
sycl/source/detail/graph_impl.hpp
Outdated
Comment on lines
1204
to
1206
| unsigned long long MID; | ||
| inline static std::atomic<unsigned long long> NextAvailableID = 0; |
There was a problem hiding this comment.
Nit but I think it's worth having a comment for these that they are only used for std::hash
| @@ -17,7 +17,7 @@ | |||
| #ifdef __INTEL_PREVIEW_BREAKING_CHANGES | |||
| #include <sycl/detail/string_view.hpp> | |||
| #endif | |||
| #include <sycl/device.hpp> // for device | |||
| #include <sycl/device.hpp> // for device | |||
There was a problem hiding this comment.
This formatting change doesn't seem to match the rest, are we sure it is correct?
There was a problem hiding this comment.
I ran clang-format on the file and it changed that line. But there is no point in changing that unrelated comment so I reverted that change.
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
reviewed
Jan 28, 2025
| @@ -0,0 +1,194 @@ | |||
| //==----------------------- CommandGraph.cpp -------------------------------==// | |||
There was a problem hiding this comment.
CommonReferenceSemantics.cpp
| sycl::queue Queue; | ||
| experimental::command_graph Graph(Queue.get_context(), Queue.get_device()); | ||
|
|
||
| auto factory = [&]() { |
There was a problem hiding this comment.
Factor more consistent variable naming
| * @param objFactory A function object that returns an object to be tested. | ||
| */ | ||
| template <typename T, typename LambdaType> | ||
| void testSemantics(LambdaType &&objFactory) { |
There was a problem hiding this comment.
Suggested change
| void testSemantics(LambdaType &&objFactory) { | |
| void testSemantics(LambdaType &&ObjFactory) { |
and the doxy comment
EwanC
changed the title
Adds missing common reference semantic functionality such as operator==, operator!= and hash functions to all sycl graph related classes.
fabiomestre
force-pushed
the
fabio/common_reference_semantics
branch
from
1db12ad to
8c9c0ea
Compare
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
fabiomestre
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing common reference semantic functionality such as operator==, operator!= and hash functions to all sycl graph related classes.