Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Remove REQUIRES: build-and-run-mode from syclcompat and Adapters tests #16795

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jan 27, 2025

As of #16725 tests can properly react to features that affect compilation on build-only mode (i.e., libraries or OS), additionally we can also mark if a test should only be built for a specific triple using the target-* features.

This pr removes REQUIRES: build-and-run-mode from syclcompat and Adapters tests, and either lets the test be marked as unsupported due to requiring a missing build feature (windows or cuda_dev_kit), or the test is marked as unsupported for spir by requiring target-nvidia

@ayylol ayylol requested review from a team as code owners January 27, 2025 16:07
@ayylol ayylol requested a review from uditagarwal97 January 27, 2025 16:07
@ayylol
Copy link
Contributor Author

ayylol commented Jan 27, 2025

note, sycl/test-e2e/Adapters/cuda_queue_priority.cpp might also need to have the cuda requirement swapped to target-nvidia, but i wasnt able to check because i do not have an environment with cuda_dev_kit readily available, this pr is mainly meant to remove REQUIRES: build-and-run-mode to get clean runs on CI.

@kbenzie
Copy link
Contributor

kbenzie commented Jan 28, 2025

note, sycl/test-e2e/Adapters/cuda_queue_priority.cpp might also need to have the cuda requirement swapped to target-nvidia, but i wasnt able to check because i do not have an environment with cuda_dev_kit readily available, this pr is mainly meant to remove REQUIRES: build-and-run-mode to get clean runs on CI.

@npmiller this is relevant to your team.

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR LGTM

@aelovikov-intel aelovikov-intel merged commit e856440 into intel:sycl Jan 28, 2025
16 of 17 checks passed
@ayylol ayylol deleted the remove-buildonly-exceptions branch January 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants