Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Install pkg-config in docker container #16797

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[CI] Install pkg-config in docker container #16797

merged 1 commit into from
Jan 27, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Jan 27, 2025 •
edited
Loading

pkg-config is required for llvm-spirv to detect spirv-tools installation.
See #16743 (comment) for more info.

@uditagarwal97
[CI] Install pkg-config in docker container
135e7d2 
`pkg-config` is required for `llvm-spirv` to detect `spirv-tools` installation.
@uditagarwal97 uditagarwal97 self-assigned this Jan 27, 2025
@uditagarwal97 uditagarwal97 marked this pull request as ready for review January 27, 2025 16:58
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner January 27, 2025 16:58
@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers I think we are good to merge this. Pending pre-commit checks can be skipped as this change is only in docker container and can be verified only in post-commit.

@sarnex sarnex merged commit 566f514 into sycl Jan 27, 2025
13 of 17 checks passed
@aelovikov-intel aelovikov-intel deleted the pkg_config branch January 27, 2025 17:27
ayylol added a commit to ayylol/intel-llvm that referenced this pull request Jan 28, 2025
@ayylol
Merge InlineAsm test changes
0e821af 
commit 7dec039
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Jan 27 10:21:05 2025 -0800

    remove IntelGPU folder, and add target-spir to lit.local.cfg

commit dccac19
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Jan 27 10:09:58 2025 -0800

    Use target features instead of backend features

commit be87b96
Merge: d83a37d e923fbb
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Jan 27 10:06:53 2025 -0800

    Merge branch 'sycl' into inlineasm-litlocal

commit e923fbb
Author: Nick Sarnie <[email protected]>
Date:   Tue Jan 28 03:01:42 2025 +0900

    [CI] Update dev-igc even if IGC CI failed (intel#16790)

    IGC public CI has been failing for months and we got confirmation even
    if the public CI fails the change has already been internally validated.
    We can confirm this change works as below:
    [Old
    link](https://api.github.com/repos/intel/intel-graphics-compiler/actions/workflows/build-IGC.yml/runs?status=success)
    [New
    link](https://api.github.com/repos/intel/intel-graphics-compiler/actions/workflows/build-IGC.yml/runs)

    Signed-off-by: Sarnie, Nick <[email protected]>

commit 4eb095e
Author: Chris Perkins <[email protected]>
Date:   Mon Jan 27 09:34:35 2025 -0800

    [SYCL] remove experimental online_compiler extension (intel#16776)

    Minus support for "CM", all the functionality of the old experimental
    online_compiler extension is being provided by the new (also
    experimental) kernel_compiler. Only better.

    Besides always being merely experimental, the online_compiler has been
    marked as deprecated for over a year, it has become burdensome to
    continue to support, and it sometimes confuses users. The decision has
    been made to remove it, without waiting for an ABI breaking window.

commit 566f514
Author: Udit Kumar Agarwal <[email protected]>
Date:   Mon Jan 27 09:27:27 2025 -0800

    [CI] Install `pkg-config` in docker container (intel#16797)

    `pkg-config` is required for `llvm-spirv` to detect `spirv-tools`
    installation.
    See intel#16743 (comment) for
    more info.

commit 367f355
Author: Mészáros Gergely <[email protected]>
Date:   Mon Jan 27 17:28:39 2025 +0100

    [SYCL][E2E][NFC] Fix NameError if directive fails to parse (intel#16767)

    Currently if a test contains a malformed directive, the following
    exception is raised along with the original parsing error:
    ```plaintext
    Exception during script execution:
    (original error)

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "llvm/llvm/utils/lit/lit/worker.py", line 76, in _execute_test_handle_errors
        result = test.config.test_format.execute(test, lit_config)
      File "llvm/sycl/test-e2e/format.py", line 232, in execute
        script = self.parseTestScript(test)
      File "llvm/sycl/test-e2e/format.py", line 105, in parseTestScript
        return lit.Test.Result(Test.UNRESOLVED, str(e))
    NameError: name 'Test' is not defined
    ```
    The test ends up as UNRESOLVED either way, but fixing it is easy and
    improves the error message greatly.

commit d83a37d
Author: Garcia Orozco, David <[email protected]>
Date:   Wed Jan 22 13:47:59 2025 -0800

    Add `InlineAsm/IntelGPU` test directory

commit 745d9b5
Merge: e91210e 34ef866
Author: Garcia Orozco, David <[email protected]>
Date:   Wed Jan 22 13:33:25 2025 -0800

    Merge branch 'sycl' into inlineasm-litlocal

commit e91210e
Merge: 8d5f517 38e6e1b
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Jan 20 11:59:42 2025 -0800

    Merge branch 'sycl' into inlineasm-litlocal

commit 8d5f517
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Dec 9 11:51:56 2024 -0800

    Add REQUIRES: gpu,linux to lit.local.cfg

commit a518866
Author: Garcia Orozco, David <[email protected]>
Date:   Mon Dec 9 11:44:21 2024 -0800

    Use lit.local.cfg to mark cuda and hip as unsupported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarnex sarnex sarnex approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uditagarwal97 @sarnex