Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compat] Remove usage of __SYCL_COMPILER_VERSION #16812

Merged
merged 1 commit into from
Jan 29, 2025
Merged

[compat] Remove usage of __SYCL_COMPILER_VERSION #16812

merged 1 commit into from
Jan 29, 2025

Conversation

JackAKirk
Copy link
Contributor

@JackAKirk JackAKirk commented Jan 28, 2025 •
edited
Loading

There should be no logic based on the compiler version within the actual compiler: it can only have one version.

Note: does not take into account time-travel :)

@JackAKirk
Remove usage of __SYCL_COMPILER_VERSION in syclcompat
3b892c1 
There should be no logic based on the compiler version within the actual compiler: it can only have one version.

Signed-off-by: JackAKirk <[email protected]>
@JackAKirk JackAKirk marked this pull request as ready for review January 28, 2025 14:43
@JackAKirk JackAKirk requested a review from a team as a code owner January 28, 2025 14:43
@JackAKirk JackAKirk requested review from joeatodd and Alcpz January 28, 2025 15:49
Alcpz
Alcpz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I agree with your assesment. __SYCL_COMPILER_VERSION made sense when these libraries didn't belong to the compiler. The version here should be irrelevant and the else path never taken.

LGTM. Thanks for tagging

@JackAKirk JackAKirk removed the request for review from joeatodd January 29, 2025 10:47
@JackAKirk
Copy link
Contributor Author

@intel/llvm-gatekeepers this is ready for merge. Thanks

@martygrant martygrant merged commit 70f92a0 into intel:sycl Jan 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alcpz Alcpz Alcpz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackAKirk @Alcpz @martygrant