[SYCL][E2E] Make layout_array.cpp use specific headers #16822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout_array test is currently prone to failure if any of the types it checks are instantiated by the headers rather than by the test itself. This means that unrelated changes to the SYCL headers may make the test fail due to one of the types being instantiated earlier than the test instantiates other types that go before it. To avoid this issue, these changes makes the test indifferent to the order of the instantiated layouts in the generated output. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
changed the title
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Jan 29, 2025
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Can we merge this PR? PVC CI tests can't finish because runner somehow can't pick this job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout_array test is currently prone to failure if any of the types it checks are instantiated by the headers rather than by the test itself. This means that unrelated changes to the SYCL headers may make the test fail due to one of the types being instantiated earlier than the test instantiates other types that go before it. To avoid this issue, this commit makes the test use specific headers, reducing the chance of instantiations.
This commit also fixes a faulty expectation in the
nd_itemtest case.