[SYCL][Bindless] Update return types for image extent queries #16829
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated return types of `max_image_linear_{dim/pitch}` to match the
Bindless Images extension specification.
While `uint32_t` is more than sufficient in most situations, CUDA uses
`size_t` values for these properties when creating textures. Vulkan
also allows implementations to use sizes greater than what can be
expressed by `uint32_t`.
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I'm assuming here that the ABI changes fall under the experimental extension exception, and are permissible to merge. |
steffenlarsen
approved these changes
Jan 29, 2025
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
DBDuncan
approved these changes
Jan 29, 2025
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers I believe this can be merged. |
aelovikov-intel
previously requested changes
Jan 29, 2025
There was a problem hiding this comment.
Some of the symbols here are just moved, likely due to the person adding them not using the tool for generating the symbols. Only ABI breaking changes here seem to be experimental, so they should be good.
That's wrong approach. Either re-generated in a separate PR prior to making your change, or manually drop unrelated changes.
aelovikov-intel
dismissed
their stale review
Ok, agree after taking more time to look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated return types of
max_image_linear_{dim/pitch}queries to match the Bindless Images extension specification.While
uint32_tis more than sufficient in most situations, CUDA usessize_tvalues for these properties when creating textures. Vulkan also allows implementations to use sizes greater than what can be expressed byuint32_t.