Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E][Joint Matrix] OOB tests to support more shapes, layouts #16837

Merged
merged 4 commits into from
Feb 3, 2025
Merged

[SYCL][E2E][Joint Matrix] OOB tests to support more shapes, layouts #16837

merged 4 commits into from
Feb 3, 2025

Conversation

YuriPlyakhin
Copy link
Contributor

No description provided.

@YuriPlyakhin YuriPlyakhin marked this pull request as ready for review January 31, 2025 20:59
@YuriPlyakhin YuriPlyakhin requested a review from a team as a code owner January 31, 2025 20:59
@YuriPlyakhin YuriPlyakhin requested a review from a team as a code owner January 31, 2025 22:21
@YuriPlyakhin YuriPlyakhin requested a review from dkhaldi January 31, 2025 22:23
aelovikov-intel
aelovikov-intel approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp LGTM.

@YuriPlyakhin YuriPlyakhin marked this pull request as draft January 31, 2025 23:53
@YuriPlyakhin YuriPlyakhin marked this pull request as ready for review February 1, 2025 00:59
YuriPlyakhin
YuriPlyakhin commented Feb 1, 2025
View reviewed changes
sycl/test-e2e/Matrix/Inputs/joint_matrix_out_bounds_impl.hpp
Comment on lines +150 to +158
test<bfloat16, float, /*MATRIX_M*/ 1024 + 20, /*MATRIX_N*/ 1024 + 20,
/*MATRIX_K*/ 1024 + 24, /*TM*/ 8, /*TN*/ 16, /*TK*/ 16, A_layout,
B_layout>();
std::cout << "half: ";
test<half, float, 1024 + 20, 1024 + 20, 1024 + 24, 8, 16, 16, A_layout,
B_layout>();
std::cout << "int8: ";
test<int8_t, int32_t, 1024, 1024 + 20, 1024 + 24, 8, 16, 32, A_layout,
B_layout>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated MATRIX_M, MATRIX_N and MATRIX_K to satisfy the requirement: Surface pitch (encoded_value + 1) must be a multiple of QW (8 bytes).

dkhaldi
dkhaldi approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriPlyakhin
Copy link
Contributor Author

@intel/llvm-gatekeepers , please, merge. Fail is not related. Created #16877

Timed Out Tests (1):
  SYCL :: Regression/multithread_write_accessor.cpp

@uditagarwal97 uditagarwal97 merged commit 8461560 into intel:sycl Feb 3, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhaldi dkhaldi dkhaldi approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuriPlyakhin @dkhaldi @aelovikov-intel @uditagarwal97