[SYCL][Graph] Refine E2E test comment #16842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code comment in `Update/FreeFunctionKernels/update_with_indices_ordering.cpp` mentions that it is unknown why the execution time is slower than the equivalent `Update/update_with_indices_ordering.cpp` test without free functions. This has now been investigated in CMPLRLLVM-64841 and has found to be due to the explicit arguments in the free function signature avoiding constant folding from lambdas. Note that we want to keep these parameters as the test is stressing the case where multiple args are passed to the free function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code comment in
Update/FreeFunctionKernels/update_with_indices_ordering.cppmentions that it is unknown why the execution time is slower than the equivalentUpdate/update_with_indices_ordering.cpptest without free functions.This has now been investigated in CMPLRLLVM-64841 and has found to be due to the explicit arguments in the free function signature avoiding constant folding from lambdas. Note that we want to keep these parameters as the test is stressing the case where multiple args are passed to the free function.