Version 1.1 #1
Merged
Version 1.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug with `preg_match` breaking UTF strings. Introduced additional classes for metadata in the HTML formatter. Introduced metadata names in the HTMLFormatter, like `Key: C` instead of just `C`. This does not apply to common metadata like "title". Re-styled metadata in the example.css. Removed chord span when there is only text in the line. Removed text span when there are only chords in the line. Added support for inline chords (Song Lyrics ~ [Am] [F]). JSON formatter supports sections instead of threating them as metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_matchbreaking UTF strings.Key: Cinstead of justC. This does not apply to common metadata like "title".