Fix error with corrupted PDF image download #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcoury thank you for the PR. I'd like to make sure I understand what problem this is trying to fix. Can we add a test for what happened so that it won't creep back in at some point? As such, could you describe the error for me so I can try and replicate it? |
|
The test was part of the commit BTW, this is not working on the main branch. |
|
@fcoury apologies, I did not intend to close this. We're working on some maintenance on these SDKs and I was moving some tickets I opened to out project board. I hope to have this issue fixed soon. |
|
Any progress here on merging this or fixing the root issue? Thanks! |
RyhanSunny
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files downloaded using the
inbound.imagemethod were resulting on corrupted PDF files.