Fix nat64 port change observing #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikitin-intermedia
requested review from
dshamaev-intermedia,
esmitenko-intermedia and
vkolesnikov-intermedia
vkolesnikov-intermedia
approved these changes
Jul 24, 2024
| )); | ||
| sip_uri->host.slen = acc.in4_addr.slen; | ||
| sip_uri->host.ptr = acc.in4_addr.ptr; | ||
| if (acc.in4_port > 0) { | ||
| if (acc.in4_port != INVALID_PORT) { |
There was a problem hiding this comment.
nit: The check isn't equivalent to previous one, now zero is valid value. Is it ok?
There was a problem hiding this comment.
This is OK, because acc.in4_port initializes with INVALID_PORT, and then updates only with values more than 0
| )); | ||
| /* Step 2. Update HPBX server addr value */ | ||
| pj_strdup_with_null(mod_pool, &hpbx.in4_addr, addr); | ||
| /* Step 3. Mark update */ |
There was a problem hiding this comment.
Let's leave it as is, because the author of this code is not me
dshamaev-intermedia
approved these changes
Jul 24, 2024
esmitenko-intermedia
approved these changes
Jul 24, 2024
anikitin-intermedia
merged commit 65200c0
into
release/im-2.14.1
12 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.