Change some pickers from "workspace folders" to "server connections" #1467
Conversation
There was a problem hiding this comment.
Nice. Just one observation from my testing so far. When I have a workspace with at least 2 folders with distinct connections to 2023.2+ servers, and I invoke Lite Terminal from the dropdown on Panel's Terminal view, I correctly get the new picker. But if I change my mind and dismiss it with Esc I get an error notification on the bottom right saying "Lite Terminal requires an active server connection to InterSystems IRIS version 2023.2 or above.". It'd be nicer to suppress that in this case, but still present it if there were no eligible connections to offer the user. I guess that'd require getWsServerConnection to give different responses in those two cases rather than undefined for both.
|
Good suggestion John. I will implement that. |
This PR fixes #1461. I added a new utility method for picking a server connection from the current workspace. It de-duplicates connections and has optional minimum server version checking. I used it for Lite Terminal and picking a process to attach to for debugging.