Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking to see if updating Rollup would improve build speed 😅 I noticed a bunch of warnings while building due to the PURE comments usage, this is new in Rollup 4 https://rollupjs.org/migration/#general-changes:~:text=Last%2C%20you%20may,can%20help%20you, so likely these comments were not actually being used.
These warnings can be seen in the build step of #1578, I've listed some of them below:
Variable assignments
Function calls
Based on https://rollupjs.org/configuration-options/#pure I'm not entirely sure why the PURE comments before a
[]
or{ [_locale]: {} }
are not supposedly incorrect, strictly speaking these also invoke a constructor right?