Added labels to the map #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 48077b1.
philippewarren
commented
Jan 25, 2022
Comment on lines
27
to
39
| - name: Install system dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install nodejs npm | ||
| sudo apt-get install nodejs npm build-essential | ||
|
|
||
| - name: Update npm | ||
| run: sudo npm install -g npm@latest | ||
| run: | | ||
| npm --version | ||
| npm install -g npm@latest | ||
| npm --version | ||
|
|
||
| - name: Install the VUE.js frontend | ||
| working-directory: catkin_ws/src/opentera-webrtc-teleop-frontend/teleop-vue |
There was a problem hiding this comment.
Related to the warnings in CI
philippewarren
commented
Jan 25, 2022
Comment on lines
1
to
22
| module.exports = { | ||
| root: true, | ||
| env: { | ||
| node: true, | ||
| node: true | ||
| }, | ||
| extends: [ | ||
| "plugin:vue/vue3-essential", | ||
| "eslint:recommended", | ||
| "@vue/typescript/recommended", | ||
| "@vue/prettier", | ||
| "@vue/prettier/@typescript-eslint", | ||
| "@vue/prettier/@typescript-eslint" | ||
| ], | ||
| parserOptions: { | ||
| ecmaVersion: 2020, | ||
| ecmaVersion: 2020 | ||
| }, | ||
| ignorePatterns: ["/submodules/*"], | ||
| rules: { | ||
| "no-console": process.env.NODE_ENV === "production" ? "warn" : "off", | ||
| "no-debugger": process.env.NODE_ENV === "production" ? "warn" : "off", | ||
| "comma-dangle": [ | ||
| "warn", | ||
| { | ||
| arrays: "always-multiline", | ||
| objects: "always-multiline", | ||
| imports: "always-multiline", | ||
| exports: "always-multiline", | ||
| functions: "never", | ||
| }, | ||
| ], | ||
| }, | ||
| "prettier/prettier": "off" | ||
| } | ||
| }; |
There was a problem hiding this comment.
Related to the warnings in CI
philippewarren
commented
Jan 25, 2022
Comment on lines
-206
to
+380
| window.addEventListener("keyup", this.onKeyUp); | ||
| window.removeEventListener("keyup", this.onKeyUp); |
There was a problem hiding this comment.
Fixed this, I assumed it was a typo
doumdi
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to introlab/opentera-webrtc-ros#37