i18n: Fixing mark for translation. #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
fix-translation-mark
branch
from
cc63fa6 to
fdec657
Compare
kpsherva
reviewed
Jun 9, 2022
| @@ -206,5 +206,5 @@ def validate_username(username): | |||
| if not re.fullmatch(username_regex, username): | |||
| # if validation fails, we raise a ValueError with the configured | |||
| # text explaining the validation rules. | |||
| message = _(current_app.config["ACCOUNTS_USERNAME_RULES_TEXT"]) | |||
| message = current_app.config["ACCOUNTS_USERNAME_RULES_TEXT"] | |||
There was a problem hiding this comment.
ACCOUNTS_USERNAME_RULES_TEXT is "double translated" in this way, I would probably only leave one of the two translation function calls, what do you think?
There was a problem hiding this comment.
ACCOUNTS_USERNAME_RULES_TEXT is an argument for current_app.config.
Currently the string ACCOUNTS_USERNAME_RULES_TEXT is marked for translation, meaning that we change this string and therefore the argument for current_app.config - not the message that is returned.
What we need to do is to translate the string that is returned as message instead. This is part of config.py and there we marked the respective string for translation.
added 2 commits
June 9, 2022 11:53
ghost
force-pushed
the
fix-translation-mark
branch
from
fdec657 to
2bd3a69
Compare
kpsherva
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #415.
Refs inveniosoftware/invenio-app-rdm#1707