views: FAIR signposting remove linkset link to itself

inveniosoftware · Dec 13, 2024 · 34eac5e · 34eac5e
1 parent 7e17fad
commit 34eac5e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/invenio_rdm_records/resources/serializers/signposting/schema.py b/invenio_rdm_records/resources/serializers/signposting/schema.py
@@ -75,6 +75,8 @@ def serialize_describedby(self, obj, **kwargs):
         result = [
             {"href": obj["links"]["self"], "type": mimetype}
             for mimetype in sorted(record_serializers)
+            # Remove the linkset serializer, so that the linkset does not link to itself.
+            if mimetype != "application/linkset+json"
         ]
 
         return result or missing

diff --git a/tests/resources/serializers/test_signposting_serializer.py b/tests/resources/serializers/test_signposting_serializer.py
@@ -33,10 +33,10 @@ def test_signposting_serializer_full(running_app, full_record_to_dict):
                         "href": "https://127.0.0.1:5000/api/records/12345-abcde",
                         "type": "application/ld+json",
                     },
-                    {
-                        "href": "https://127.0.0.1:5000/api/records/12345-abcde",
-                        "type": "application/linkset+json",
-                    },
+                    # {
+                    #     "href": "https://127.0.0.1:5000/api/records/12345-abcde",
+                    #     "type": "application/linkset+json",
+                    # },
                     {
                         "href": "https://127.0.0.1:5000/api/records/12345-abcde",
                         "type": "application/marcxml+xml",
@@ -146,10 +146,10 @@ def test_signposting_serializer_minimal(running_app, minimal_record_to_dict):
                         "href": "https://127.0.0.1:5000/api/records/67890-fghij",
                         "type": "application/ld+json",
                     },
-                    {
-                        "href": "https://127.0.0.1:5000/api/records/67890-fghij",
-                        "type": "application/linkset+json",
-                    },
+                    # {
+                    #     "href": "https://127.0.0.1:5000/api/records/67890-fghij",
+                    #     "type": "application/linkset+json",
+                    # },
                     {
                         "href": "https://127.0.0.1:5000/api/records/67890-fghij",
                         "type": "application/marcxml+xml",