Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1846 #1859

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

karkraeg
Copy link
Member

@karkraeg karkraeg commented Oct 25, 2024

❤️ Thank you for your contribution!

Description

This picks up the config value introduced in inveniosoftware/invenio-app-rdm#2889 in the delete draft function to handle the redirect target.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Member

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karkraeg karkraeg requested a review from zzacharo October 29, 2024 12:06
@karkraeg
Copy link
Member Author

karkraeg commented Nov 6, 2024

To me it looks like the failing test has nothing to with my change? https://github.com/inveniosoftware/invenio-rdm-records/actions/runs/11698492858/job/32578870862?pr=1859#step:6:3894

@zzacharo
Copy link
Member

zzacharo commented Nov 6, 2024

Failing tests should related to the latest release of https://pypi.org/project/marshmallow-utils/ and the edtf bump to v5.0. We can fix them as part of #1870

@zzacharo zzacharo merged commit 5cfab12 into inveniosoftware:master Nov 6, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants