Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use uow not self.uow #1926

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

utnapischtim
Copy link
Contributor

  • fix: use uow not self.uow

@utnapischtim utnapischtim requested a review from slint January 13, 2025 15:52
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the change, not sure though what in the end should be the convention we follow for passing the UoW to components, i.e. rely on class attribute and self.uow vs. explicit parameter.

I somewhat like the class attribute since it makes the method signatures smaller/simpler and more focused on the action.

@utnapischtim
Copy link
Contributor Author

the problem is, that self.uow is not set in this class. the new base class doesn't handle the case to set self.uow.

@slint
Copy link
Member

slint commented Jan 14, 2025

the problem is, that self.uow is not set in this class. the new base class doesn't handle the case to set self.uow.

Thanks, I didn't check the context and thought this was a component class 😅

In that case, I guess it's necessary so this is good to merge :)

@slint slint merged commit 3f81209 into inveniosoftware:master Jan 14, 2025
4 checks passed
@utnapischtim utnapischtim deleted the fix-uow branch January 14, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants