-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analysis.setContextRoots failed when DAS launched from Android Studio #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mac launched with no env variables
@EricSchlichting is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/dart_custom_lint~304 Documentation is deployed and generated using docs.page. |
EricSchlichting
changed the title
Fix analysis.setContextRoots failed on Android Studio
Fix analysis.setContextRoots failed when DAS launched from Android Studio
Jan 14, 2025
rrousselGit
reviewed
Jan 14, 2025
…other example project, get custom_lint running successfully in example_plugin
rrousselGit
reviewed
Jan 21, 2025
rrousselGit
reviewed
Jan 21, 2025
@rrousselGit this is ready for your re-review |
This was
linked to
issues
Jan 28, 2025
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #270.
Android Studio launches dart analysis server with a very limited PATH variable. Because of this just using the command
flutter
ordart
fails since those executables are not on the limited PATH.If we instead use
Platform.resolvedExecutable
it gives us a full path to the dart executable used to run the custom lint plugin.I removed the consideration for running
flutter pub get
since it looks likeflutter pub get
runs dart pub get under the hood and it worked fine in my testing.