Test/signin functional test #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 24, 2016 08:09
sinon.spy() => sinon.spy(Object, method)
add file src/components/auth/registerUser.functional.spec.js add file .travis.yml for travis-ci
add src/components/auth/loginUser.functional.spec.js it's for login user functional test.
| return new signInCtrl($auth, $state, $toast); | ||
| }; | ||
| })); | ||
| it('signin form test', function() { |
There was a problem hiding this comment.
This part should be defined as Unit Test.
And every test should be separated.
added 2 commits
March 28, 2016 10:11
change describe to when doing something. change it to when should doing something.
Remove unit test thing in loginUser and registerUser. Change describe and it usage.
|
This PR has conflicts. Please resolve it. |
JuliusChen
pushed a commit
that referenced
this pull request
Mar 21, 2017
Confirm translation and Remove needless judgment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.